test(client): debuggability via console or debugger #25351
Merged
+117
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieHabi
previously approved these changes
Aug 29, 2025
jason-ha
force-pushed
the
presence/test/readonly-client-support
branch
from
71f55fd to
e414272
Compare
jason-ha
force-pushed
the
presence/test/console-debuggability
branch
from
1364386 to
8fae418
Compare
jason-ha
force-pushed
the
presence/test/readonly-client-support
branch
from
e414272 to
ca2c5b4
Compare
jason-ha
force-pushed
the
presence/test/console-debuggability
branch
from
8fae418 to
1781491
Compare
jason-ha
changed the title
jason-ha
changed the base branch from
presence/test/readonly-client-support
to
main
jason-ha
force-pushed
the
presence/test/console-debuggability
branch
from
1781491 to
84d3389
Compare
github-actions
bot
added
area: runtime
- log extra error from test process to console without mocha redirection - use FLUID_TEST_VERBOSE to control child logging that now optional outputs messaging and select telemetry
- For longer test cases, modify that case's timeout without impacting general timeouts. - Detect when debugger is attached and alter timeouts to increase by x1000
jason-ha
force-pushed
the
presence/test/console-debuggability
branch
from
84d3389 to
e1008e4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances test debuggability by adding console logging controls and debugger timeout handling for multi-process end-to-end tests. The changes enable better visibility into test execution and prevent debugging timeouts.
- Adds debugger detection and automatic timeout adjustment (x1000 multiplier when debugger attached)
- Implements FLUID_TEST_VERBOSE environment variable to control child process logging verbosity
- Introduces testConsole to capture original console methods before test infrastructure modifications
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| presenceTest.spec.ts | Adds debugger detection, timeout management, and dynamic test timeout setting |
| orchestratorUtils.ts | Implements testConsole capture and child logging verbosity controls |
| childClient.ts | Adds selective telemetry logging and message verbosity based on environment variable |
| package.json | Adds new npm scripts for verbose and very verbose test execution |
...ges/service-clients/end-to-end-tests/azure-client/src/test/multiprocess/presenceTest.spec.ts
Show resolved
Hide resolved
...ges/service-clients/end-to-end-tests/azure-client/src/test/multiprocess/orchestratorUtils.ts
Show resolved
Hide resolved
...ges/service-clients/end-to-end-tests/azure-client/src/test/multiprocess/orchestratorUtils.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console logging updates:
Under debugger updates: